Re: bug: git-sh-setup should not be in $PATH

From: Han-Wen Nienhuys <hanwen@xs4all.nl>
Date: Dec 6, 2006, 16:03 UTC
Message-ID: <4576E9DF.5090709@xs4all.nl>
In-Reply-To: <200612061656.55888.jnareb@gmail.com>

Jakub Narebski escreveu:

Show 12 quoted lines

> The fact that I didn't understood what this part of patch is meant
> to do should be the big hint that this commit needs some longer commit
> message explaining purpose of such mess.
> 
> I still don't understand what this part do (and how come it is
> in configure.ac which should be _only_ about generating 
> config.mak.autogen Makefile configuration file and _not_ about
> generating Makefiles). You want what sequence of commands to work?
> 
>   $ $srcdir/configure --srcdir=$srcdir
>   $ make -D $srcdir
>   $ make -D $srcdir DESTDIR=$DESTDIR install

make -D doesn't exist.

This is about

  mkdir git-build
  cd git-build
  $my_git_source/configure  
  make

this _was_ actually documented in that one-line commit message, that you found to be too short.

Since git does recursive makes, among others in

 perl/ 
 Documentation/
 templates/
 contrib/
  
there should be Makefiles in said directories. Otherwise, every rule
in the toplevel Makefile saying

  $(MAKE) -C subdir/

will fail because $builddir/ does not have a Makefile in $builddir/subdir.

The part you don't understand is a generic way of duplicating the Makefiles from the git sources, while making sure that they work when $srcdir != $builddir

Yes, if builddir != srcdir , then configure is about more than generating config.mak.autogen