git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/3] meson: don't install git-pack-redundant(1) docs with breaking changes

From
PWPhillip Wood <phillip.wood123@gmail.com>
Date
Mar 16, 2025, 15:19 UTC
Message-ID
<44a3ad4e-fb50-447f-bb66-f43b5c5ae012@gmail.com>
In-Reply-To
<20250312-b4-pks-meson-breaking-changes-v1-3-b89e9a59d228@pks.im>
Hi Patrick
On 12/03/2025 13:17, Patrick Steinhardt wrote:
Thanks for taking this forward
Show 19 quoted lines
> +manpages_breaking_changes = {
> +  'git-pack-redundant.adoc' : 1,
> +}
> +
> +if not get_option('breaking_changes')
> +  manpages += manpages_breaking_changes
> +endif
> +
>   docs_backend = get_option('docs_backend')
>   if docs_backend == 'auto'
>     if find_program('asciidoc', dirs: program_path, required: false).found()
> @@ -479,7 +486,9 @@ endif
>   # Sanity check that we are not missing any tests present in 't/'. This check
>   # only runs once at configure time and is thus best-effort, only. Furthermore,
>   # it only verifies man pages for the sake of simplicity.
> -configured_manpages = manpages.keys() + [ 'git-bisect-lk2009.adoc', 'git-tools.adoc' ]
> +configured_manpages = manpages.keys()
> +configured_manpages += manpages_breaking_changes.keys()
> +configured_manpages += [ 'git-bisect-lk2009.adoc', 'git-tools.adoc' ]

I don't think we need this hunk as we add manpages_breaking_changes into manpages in the hunk above.

Best Wishes
Phillip
Previous: Karthik NayakNext: Patrick Steinhardt
Message 6 of 11 in “meson: improve handling of `-Dbreaking_changes=true`”
  1. 0/3 meson: improve handling of `-Dbreaking_changes=true`Patrick Steinhardt, Mar 12, 2025
  2. 1/3 meson: define WITH_BREAKING_CHANGES when enabling breaking changesPatrick Steinhardt, Mar 12, 2025
  3. 2/3 meson: don't compile git-pack-redundant(1) with breaking changesPatrick Steinhardt, Mar 12, 2025
  4. 3/3 meson: don't install git-pack-redundant(1) docs with breaking changesPatrick Steinhardt, Mar 12, 2025
  5. Karthik NayakMar 13, 2025
  6. Phillip WoodMar 16, 2025
  7. Patrick SteinhardtMar 17, 2025
  8. Phillip WoodMar 17, 2025
  9. Phillip WoodMar 18, 2025
  10. Patrick SteinhardtMar 19, 2025
  11. Karthik NayakMar 13, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.