Re: [PATCH 0/3] meson: improve handling of `-Dbreaking_changes=true`

From: Karthik Nayak <karthik.188@gmail.com>
Date: Mar 13, 2025, 11:08 UTC
Message-ID: <CAOLa=ZR6Y1rE7BmJ-gUov_b9DNPs1q7ZDz0v0uUShkN6vVtDjw@mail.gmail.com>
In-Reply-To: <20250312-b4-pks-meson-breaking-changes-v1-0-b89e9a59d228@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

Show 11 quoted lines

> Hi,
>
> this small patch series improves handling of the breaking changes option
> with the Meson build system as discussed in the thread starting at [1].
>
> Thanks!
>
> Patrick
>
> [1]: <56cf842a-7c1f-4354-b191-35bcc1e139bd@gmail.com>
>

Thanks for picking this up. I think the series looks good, and is inline with the discussion we had earlier.

Show 15 quoted lines

> ---
> Patrick Steinhardt (3):
>       meson: define WITH_BREAKING_CHANGES when enabling breaking changes
>       meson: don't compile git-pack-redundant(1) with breaking changes
>       meson: don't install git-pack-redundant(1) docs with breaking changes
>
>  Documentation/Makefile    |  2 +-
>  Documentation/meson.build | 13 +++++++++++--
>  meson.build               | 18 +++++++++++-------
>  3 files changed, 23 insertions(+), 10 deletions(-)
>
>
> ---
> base-commit: 87a0bdbf0f72b7561f3cd50636eee33dcb7dbcc3
> change-id: 20250312-b4-pks-meson-breaking-changes-819afcca2e07