From: Phillip Wood <phillip.wood123@gmail.com>
Date: Sun, 16 Mar 2025 15:19:48 GMT
Subject: Re: [PATCH 3/3] meson: don't install git-pack-redundant(1) docs with breaking changes
Message-ID: <44a3ad4e-fb50-447f-bb66-f43b5c5ae012@gmail.com>
In-Reply-To: <20250312-b4-pks-meson-breaking-changes-v1-3-b89e9a59d228@pks.im>

Hi Patrick

On 12/03/2025 13:17, Patrick Steinhardt wrote:

Thanks for taking this forward

> +manpages_breaking_changes = {
> +  'git-pack-redundant.adoc' : 1,
> +}
> +
> +if not get_option('breaking_changes')
> +  manpages += manpages_breaking_changes
> +endif
> +
>   docs_backend = get_option('docs_backend')
>   if docs_backend == 'auto'
>     if find_program('asciidoc', dirs: program_path, required: false).found()
> @@ -479,7 +486,9 @@ endif
>   # Sanity check that we are not missing any tests present in 't/'. This check
>   # only runs once at configure time and is thus best-effort, only. Furthermore,
>   # it only verifies man pages for the sake of simplicity.
> -configured_manpages = manpages.keys() + [ 'git-bisect-lk2009.adoc', 'git-tools.adoc' ]
> +configured_manpages = manpages.keys()
> +configured_manpages += manpages_breaking_changes.keys()
> +configured_manpages += [ 'git-bisect-lk2009.adoc', 'git-tools.adoc' ]

I don't think we need this hunk as we add manpages_breaking_changes into 
manpages in the hunk above.

Best Wishes

Phillip