git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] tar-tree: add the "tar.applyUmask" config option

From
RDRogan Dawes <discard@dawes.za.net>
Date
Jul 20, 2006, 09:44 UTC
Message-ID
<44BF507A.4080801@dawes.za.net>
In-Reply-To
<20060720093044.GA10824@1wt.eu>
Willy Tarreau wrote:
Show 8 quoted lines
> +int git_tar_config(const char *var, const char *value)
> +{
> +	if (!strcmp(var, "tar.umask")) {
> +		if (!strcmp(value, "user")) {
> +			tar_umask = umask(0);
> +			umask(tar_umask);
> +		} else {
> +			tar_umask = git_config_int(var, value);
Looks like you forgot:
    			umask(tar_umask);
Show 5 quoted lines
> +		}
> +		return 0;
> +	}
> +	return git_default_config(var, value);
> +}
Or else move it to just before the "return 0;" line.
Rogan
Previous: Willy TarreauNext: Willy Tarreau
Message 5 of 9 in “tar-tree: add the "tar.applyUmask" config option”
  1. tar-tree: add the "tar.applyUmask" config optionWilly Tarreau, Jul 19, 2006
  2. Junio C HamanoJul 19, 2006
  3. Willy TarreauJul 19, 2006
  4. Willy TarreauJul 20, 2006
  5. Rogan DawesJul 20, 2006
  6. Willy TarreauJul 20, 2006
  7. Johannes SchindelinJul 19, 2006
  8. Rene ScharfeJul 20, 2006
  9. Junio C HamanoJul 24, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.