From: Rogan Dawes <discard@dawes.za.net>
Date: Thu, 20 Jul 2006 09:44:26 GMT
Subject: Re: [PATCH] tar-tree: add the "tar.applyUmask" config option
Message-ID: <44BF507A.4080801@dawes.za.net>
In-Reply-To: <20060720093044.GA10824@1wt.eu>

Willy Tarreau wrote:
> +int git_tar_config(const char *var, const char *value)
> +{
> +	if (!strcmp(var, "tar.umask")) {
> +		if (!strcmp(value, "user")) {
> +			tar_umask = umask(0);
> +			umask(tar_umask);
> +		} else {
> +			tar_umask = git_config_int(var, value);

Looks like you forgot:
    			umask(tar_umask);

> +		}
> +		return 0;
> +	}
> +	return git_default_config(var, value);
> +}

Or else move it to just before the "return 0;" line.

Rogan