Re: [PATCH] tar-tree: add the "tar.applyUmask" config option

From: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>
Date: Jul 20, 2006, 08:14 UTC
Message-ID: <44BF3B4A.5040109@lsrfire.ath.cx>
In-Reply-To: <20060719214025.GA10997@1wt.eu>

Hi Willy,

I kind of like the change, because it gives the user more control. Theoretically this would not be needed, because tar can apply the umask at extract time just fine. In practice I can't see why we should forbid users from creating the archives just the way they like them, no matter what their reasoning might be.

Willy Tarreau schrieb:

Show 8 quoted lines

> +tar.applyUmask::
> +	By default, git-link:git-tar-tree[1] sets file and directories modes
> +	to 0666 or 0777. While this is both useful and acceptable for projects
> +	such as the Linux Kernel, it might be excessive for other projects.
> +	Setting this variable to true makes git-link:git-tar-tree[1] apply the
> +	umask to the modes above. This should be enough for most projects, as
> +	it will lead to the same permissions as git-link:git-checkout[1] would
> +	use. The default is false.

Comments about why this change is needed and that it is sufficient should go into the commit message. For the rest of the patch:

Acked-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>