git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/RFC 1/7] imap-send: use separate read and write fds

From
Erik Faye-Lund <kusmabite@googlemail.com>
Date
Oct 3, 2009, 18:44 UTC
Message-ID
<40aa078e0910031144r735a6fdq25efc1e57a1d4c33@mail.gmail.com>
In-Reply-To
<20091003094049.GA17873@coredump.intra.peff.net>
On Sat, Oct 3, 2009 at 2:40 AM, Jeff King <peff@peff.net> wrote:
Show 10 quoted lines
> On Sat, Oct 03, 2009 at 12:39:39AM +0000, Erik Faye-Lund wrote:
>
>> Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
>
> Why? Given its presence in this series, I can only assume it has to do
> with windows portability, but it would be helpful to give a little bit
> of the reasoning in the commit message.
>
> -Peff
>
Yeah, this is about Windows portability.

I'll add something like "This is a patch that enables us to use the run-command API, which is supported on Windows." to the commit-message in the next round. Is that enough?

I also guess I should have made a cover letter for this series, making
it apparent to reviewers that:
- This patch series is about supporting imap-send on Windows
- It needs some additional patching to get tunnelling support working
on Windows, because we can't exec "/bin/sh" there. Changing it to
"c:\\msysgit\\bin\\sh.exe" makes tunneling work for me, but isn't
exactly portable across installations.
I'll write one up for the next round.
-- 
Erik "kusma" Faye-Lund
kusmabite@gmail.com
(+47) 986 59 656
Previous: Jeff KingNext: Jeff King
Message 16 of 18 in “imap-send: use separate read and write fds”
  1. 1/7 imap-send: use separate read and write fdsErik Faye-Lund, Oct 3, 2009
  2. 2/7 imap-send: use run-command API for tunnelingErik Faye-Lund, Oct 3, 2009
  3. 3/7 imap-send: fix compilation-error on WindowsErik Faye-Lund, Oct 3, 2009
  4. 4/7 imap-send: build imap-send on WindowsErik Faye-Lund, Oct 3, 2009
  5. 5/7 imap-send: provide fall-back random-sourceErik Faye-Lund, Oct 3, 2009
  6. 6/7 mingw: wrap SSL_set_(w|r)fd to call _get_osfhandleErik Faye-Lund, Oct 3, 2009
  7. 7/7 mingw: enable OpenSSLErik Faye-Lund, Oct 3, 2009
  8. Jeff KingOct 3, 2009
  9. Erik Faye-LundOct 3, 2009
  10. Erik Faye-LundOct 3, 2009
  11. Jeff KingOct 3, 2009
  12. Jeff KingOct 3, 2009
  13. Erik Faye-LundOct 8, 2009
  14. Jeff KingOct 9, 2009
  15. Jeff KingOct 3, 2009
  16. Erik Faye-LundOct 3, 2009
  17. Jeff KingOct 3, 2009
  18. Johannes SixtOct 3, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.