From: Erik Faye-Lund <kusmabite@googlemail.com>
Date: Sat, 03 Oct 2009 18:44:50 GMT
Subject: Re: [PATCH/RFC 1/7] imap-send: use separate read and write fds
Message-ID: <40aa078e0910031144r735a6fdq25efc1e57a1d4c33@mail.gmail.com>
In-Reply-To: <20091003094049.GA17873@coredump.intra.peff.net>


On Sat, Oct 3, 2009 at 2:40 AM, Jeff King <peff@peff.net> wrote:
> On Sat, Oct 03, 2009 at 12:39:39AM +0000, Erik Faye-Lund wrote:
>
>> Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
>
> Why? Given its presence in this series, I can only assume it has to do
> with windows portability, but it would be helpful to give a little bit
> of the reasoning in the commit message.
>
> -Peff
>

Yeah, this is about Windows portability.

I'll add something like "This is a patch that enables us to use the
run-command API, which is supported on Windows." to the commit-message
in the next round. Is that enough?

I also guess I should have made a cover letter for this series, making
it apparent to reviewers that:
- This patch series is about supporting imap-send on Windows
- It needs some additional patching to get tunnelling support working
on Windows, because we can't exec "/bin/sh" there. Changing it to
"c:\\msysgit\\bin\\sh.exe" makes tunneling work for me, but isn't
exactly portable across installations.

I'll write one up for the next round.

-- 
Erik "kusma" Faye-Lund
kusmabite@gmail.com
(+47) 986 59 656