git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/RFC 5/7] imap-send: provide fall-back random-source

From
Erik Faye-Lund <kusmabite@googlemail.com>
Date
Oct 3, 2009, 18:45 UTC
Message-ID
<40aa078e0910031145l2849697ftd2da2f5aaa28d957@mail.gmail.com>
In-Reply-To
<20091003095811.GB17873@coredump.intra.peff.net>
On Sat, Oct 3, 2009 at 2:58 AM, Jeff King <peff@peff.net> wrote:
Show 9 quoted lines
>
> Hmm. It looks like this arc4 RNG is used just for generating a unique
> "X-TUID" header. Which seems to be used in isync (from which imap-send
> is derived) to be to avoid duplicates in synchronization. But imap-send
> doesn't actually use it for anything, as it just blindly pushes the
> messages.
>
> In other words, should all of this TUID code (and the arc4 code) simply
> be ripped out?

Possibly. I must admit that I didn't dig far on this one - I just added some randomness, and saw that things worked for me.

I tried to trace this a little bit, but I got lost a bit in the callback-stuff. However, it looks to me like it might get sent to the server: it gets injected into cb.data in imap_store_msg(), and in v_issue_imap_cmd() it gets sent to the server if the LITERALPLUS capability is supported. I might be wrong though, as I find this code quite confusing.

I CC'ed Mike McCormack, who initially added imap-send (including the arc4 code), as he *might* have more insight on this. It's a long-shot though, considering that this appears to be code adapted around 3.5 years ago.

-- 
Erik "kusma" Faye-Lund
kusmabite@gmail.com
(+47) 986 59 656
Previous: Jeff KingNext: Erik Faye-Lund
Message 9 of 18 in “imap-send: use separate read and write fds”
  1. 1/7 imap-send: use separate read and write fdsErik Faye-Lund, Oct 3, 2009
  2. 2/7 imap-send: use run-command API for tunnelingErik Faye-Lund, Oct 3, 2009
  3. 3/7 imap-send: fix compilation-error on WindowsErik Faye-Lund, Oct 3, 2009
  4. 4/7 imap-send: build imap-send on WindowsErik Faye-Lund, Oct 3, 2009
  5. 5/7 imap-send: provide fall-back random-sourceErik Faye-Lund, Oct 3, 2009
  6. 6/7 mingw: wrap SSL_set_(w|r)fd to call _get_osfhandleErik Faye-Lund, Oct 3, 2009
  7. 7/7 mingw: enable OpenSSLErik Faye-Lund, Oct 3, 2009
  8. Jeff KingOct 3, 2009
  9. Erik Faye-LundOct 3, 2009
  10. Erik Faye-LundOct 3, 2009
  11. Jeff KingOct 3, 2009
  12. Jeff KingOct 3, 2009
  13. Erik Faye-LundOct 8, 2009
  14. Jeff KingOct 9, 2009
  15. Jeff KingOct 3, 2009
  16. Erik Faye-LundOct 3, 2009
  17. Jeff KingOct 3, 2009
  18. Johannes SixtOct 3, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.