Re: [PATCH 4/4] format-rev: learn --abbrev, --color, and --date
- From
- Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
- Date
- Aug 18, 2026, 05:11 UTC
- Message-ID
- <3a55c58f-1ada-414c-a35d-40590c635b82@app.fastmail.com>
- In-Reply-To
- <format-rev_three_more_opts.b84@msgid.xyz>
On Thu, Aug 13, 2026, at 19:24, kristofferhaugsbakk@fastmail.com wrote:
Show 7 quoted lines
>[snip]
> +static int date_cb(const struct option *option,
> + const char *arg,
> + int unset)
> +{
> + struct rev_info *data = option->value;
> + parse_date_format(arg, &data->date_mode);The documentation for this function says that we need to call a release function in case a custom format was used. That is currently missing.
Show 6 quoted lines
> + data->date_mode_explicit = 1; > + BUG_ON_OPT_NEG(unset); > + return 0; > +} > + >[snip]