Re: [PATCH v2 0/5] format-rev: add --abbrev, --color, and --date
- From
Ben Knoble <ben.knoble@gmail.com>
- Date
- Sep 3, 2026, 15:07 UTC
- Message-ID
- <EBCF44E8-9952-454F-A164-0B7CF273FB30@gmail.com>
- In-Reply-To
- <xmqqse40ei5f.fsf@gitster.g>
Show 32 quoted lines
> Le 26 août 2026 à 16:33, Junio C Hamano <gitster@pobox.com> a écrit : > > kristofferhaugsbakk@fastmail.com writes: > >> From: Kristoffer Haugsbakk <code@khaugsbakk.name> >> >> Topic name (applied): kh/format-rev-more-options >> >> Topic summary: Add three more options for controlling the formatting. Also >> do some minor refactoring and text fixes as preparatory steps. >> >> § Changes in v2 >> >> See the patch notes for details. >> >> • Use designated initializer syntax. That’s more readable since you pair >> the field with the value and you can omit zero-value fields. >> >> https://lore.kernel.org/git/xmqqfr0hswxm.fsf@gitster.g/ >> • Fix useless `BUG` placements https://lore.kernel.org/git/xmqqfr0hswxm.fsf@gitster.g/ >> • Add preliminary patch “place BUG calls first in callback” for existing >> `BUG` statement placement >> • Based on the previous point >> • Patch “learn --abbrev, --color, and --date”: test a few more options > > Nobody is interested in reviewing these patches? They looked more > or less OKish to me, but I am not the best person to review this > series, as I do not see much point in this experimental command. > It would be nice to see reviews from those who are more invested > in seeing the command work better than I am. > > Thanks.
Reviewing these are on my list. They’ve been there for a while, now, though, and no promises on timing :/ my personal priorities shifted rather quickly for the weekend with the recent 1Password announcement ://
PS hopefully this wrapping is better from my mobile device, I’m guessing at the width to hard-break as roughly 1.3 screen lines :)