From: Kristoffer Haugsbakk Date: Tue, 18 Aug 2026 05:11:17 GMT Subject: Re: [PATCH 4/4] format-rev: learn --abbrev, --color, and --date Message-ID: <3a55c58f-1ada-414c-a35d-40590c635b82@app.fastmail.com> In-Reply-To: On Thu, Aug 13, 2026, at 19:24, kristofferhaugsbakk@fastmail.com wrote: >[snip] > +static int date_cb(const struct option *option, > + const char *arg, > + int unset) > +{ > + struct rev_info *data = option->value; > + parse_date_format(arg, &data->date_mode); The documentation for this function says that we need to call a release function in case a custom format was used. That is currently missing. > + data->date_mode_explicit = 1; > + BUG_ON_OPT_NEG(unset); > + return 0; > +} > + >[snip]