[PATCH v4 9/9] show_date_ident(): defer date overflow check
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Apr 21, 2017, 10:46 UTC
- Message-ID
- <3a33b168e96c676592154dc1313a5bdea989831e.1492771484.git.johannes.schindelin@gmx.de>
- In-Reply-To
- <cover.1492771484.git.johannes.schindelin@gmx.de>
Now that we use uintmax_t for timestamps, we can represent timestamps that would not fit inside the time_t data type. As long as we do not have to use the system functions, we can even display them, e.g. as Unix epoch.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> --- pretty.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/pretty.c b/pretty.c index 587d48371b0..35fd290096a 100644 --- a/pretty.c +++ b/pretty.c @@ -410,14 +410,10 @@ const char *show_ident_date(const struct ident_split *ident, if (ident->date_begin && ident->date_end) date = parse_timestamp(ident->date_begin, NULL, 10); - if (date_overflows(date)) - date = 0; - else { - if (ident->tz_begin && ident->tz_end) - tz = strtol(ident->tz_begin, NULL, 10); - if (tz >= INT_MAX || tz <= INT_MIN) - tz = 0; - } + if (ident->tz_begin && ident->tz_end) + tz = strtol(ident->tz_begin, NULL, 10); + if (tz >= INT_MAX || tz <= INT_MIN) + tz = 0; return show_date(date, tz, mode); }
-- 2.12.2.windows.2.406.gd14a8f8640f