Re: [PATCH v5 8/8] Use uintmax_t for timestamps

From

Johannes Sixt <j6t@kdbg.org>

Date

Apr 26, 2017, 16:36 UTC

Message-ID

<02b74d66-97e6-c633-888a-0c6a628cc5bd@kdbg.org>

In-Reply-To

<50b62ed69c3239c076c28c5048bbd07396a25c5c.1493042239.git.johannes.schindelin@gmx.de>

Am 24.04.2017 um 15:58 schrieb Johannes Schindelin:

>  #define PRIo32 "o"
>  #endif
>  
> -typedef unsigned long timestamp_t;
> -#define PRItime "lu"
> -#define parse_timestamp strtoul
> +typedef uintmax_t timestamp_t;
> +#define PRItime PRIuMAX
> +#define parse_timestamp strtoumax
> +#ifdef ULLONG_MAX
> +#define TIME_MAX ULLONG_MAX
> +#else
>  #define TIME_MAX ULONG_MAX
> +#endif
>  
>  #ifndef PATH_SEP
>  #define PATH_SEP ':'
> 

I think you should squash in this:

diff --git a/git-compat-util.h b/git-compat-util.h
index 26d2643667..b5f4a7bb2f 100644
--- a/git-compat-util.h
+++ b/git-compat-util.h
@@ -322,11 +322,7 @@ extern char *gitdirname(char *);
 typedef uintmax_t timestamp_t;
 #define PRItime PRIuMAX
 #define parse_timestamp strtoumax
-#ifdef ULLONG_MAX
-#define TIME_MAX ULLONG_MAX
-#else
-#define TIME_MAX ULONG_MAX
-#endif
+#define TIME_MAX UINTMAX_MAX
 
 #ifndef PATH_SEP
 #define PATH_SEP ':'

UINTMAX_MAX is already used git-compat-util.h

-- Hannes