git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 0/3] Add GIT_TEST_MULTI_PACK_INDEX environment variable

From
Derrick Stolee <stolee@gmail.com>
Date
Oct 12, 2018, 17:41 UTC
Message-ID
<38aff549-9582-9879-9b3d-81cf5b1c3e24@gmail.com>
In-Reply-To
<pull.27.v2.git.gitgitgadget@gmail.com>
On 10/12/2018 1:34 PM, Derrick Stolee via GitGitGadget wrote:
Show 32 quoted lines
> To increase coverage of the multi-pack-index feature, add a
> GIT_TEST_MULTI_PACK_INDEX environment variable similar to other GIT_TEST_*
> variables.
>
> After creating the environment variable and running the test suite with it
> enabled, I found a few bugs in the multi-pack-index implementation. These
> are handled by the first two patches.
>
> I have set up a CI build on Azure Pipelines [1] that runs the test suite
> with a few optional features enabled, including GIT_TEST_MULTI_PACK_INDEX
> and GIT_TEST_COMMIT_GRAPH. I'll use this to watch the features and ensure
> they work well with the rest of the ongoing work. Eventually, we can add
> these variables to the Travis CI scripts.
>
> [1] https://git.visualstudio.com/git/_build?definitionId=4
>
> Derrick Stolee (3):
>    midx: fix broken free() in close_midx()
>    midx: close multi-pack-index on repack
>    multi-pack-index: define GIT_TEST_MULTI_PACK_INDEX
>
>   builtin/repack.c            |  7 +++++--
>   midx.c                      | 26 ++++++++++++++++++++------
>   midx.h                      |  6 +++++-
>   t/README                    |  4 ++++
>   t/t5310-pack-bitmaps.sh     |  1 +
>   t/t5319-multi-pack-index.sh |  2 +-
>   t/t9300-fast-import.sh      |  2 +-
>   7 files changed, 37 insertions(+), 11 deletions(-)
>
>
> base-commit: 5a0cc8aca797dbd7d2be3b67458ff880ed45cddf

I should explicitly mention that this base commit is different as otherwise I will conflict with ds/multi-pack-verify with the new prototype in midx.h.

Thanks, -Stolee

Previous: Derrick Stolee via GitGitGadgetNext: Junio C Hamano
Message 13 of 14 in “Add GIT_TEST_MULTI_PACK_INDEX environment variable”
  1. 0/3 Add GIT_TEST_MULTI_PACK_INDEX environment variableDerrick Stolee via GitGitGadget, Oct 8, 2018
  2. 1/3 midx: fix broken free() in close_midx()Derrick Stolee via GitGitGadget, Oct 8, 2018
  3. Junio C HamanoOct 9, 2018
  4. 2/3 midx: close multi-pack-index on repackDerrick Stolee via GitGitGadget, Oct 8, 2018
  5. Junio C HamanoOct 9, 2018
  6. Derrick StoleeOct 9, 2018
  7. Stefan BellerOct 9, 2018
  8. 3/3 multi-pack-index: define GIT_TEST_MULTI_PACK_INDEXDerrick Stolee via GitGitGadget, Oct 8, 2018
  9. 0/3 Add GIT_TEST_MULTI_PACK_INDEX environment variableDerrick Stolee via GitGitGadget, Oct 12, 2018
  10. 1/3 midx: fix broken free() in close_midx()Derrick Stolee via GitGitGadget, Oct 12, 2018
  11. 3/3 multi-pack-index: define GIT_TEST_MULTI_PACK_INDEXDerrick Stolee via GitGitGadget, Oct 12, 2018
  12. 2/3 midx: close multi-pack-index on repackDerrick Stolee via GitGitGadget, Oct 12, 2018
  13. Derrick StoleeOct 12, 2018
  14. Junio C HamanoOct 22, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.