From: Derrick Stolee Date: Fri, 12 Oct 2018 17:41:02 GMT Subject: Re: [PATCH v2 0/3] Add GIT_TEST_MULTI_PACK_INDEX environment variable Message-ID: <38aff549-9582-9879-9b3d-81cf5b1c3e24@gmail.com> In-Reply-To: On 10/12/2018 1:34 PM, Derrick Stolee via GitGitGadget wrote: > To increase coverage of the multi-pack-index feature, add a > GIT_TEST_MULTI_PACK_INDEX environment variable similar to other GIT_TEST_* > variables. > > After creating the environment variable and running the test suite with it > enabled, I found a few bugs in the multi-pack-index implementation. These > are handled by the first two patches. > > I have set up a CI build on Azure Pipelines [1] that runs the test suite > with a few optional features enabled, including GIT_TEST_MULTI_PACK_INDEX > and GIT_TEST_COMMIT_GRAPH. I'll use this to watch the features and ensure > they work well with the rest of the ongoing work. Eventually, we can add > these variables to the Travis CI scripts. > > [1] https://git.visualstudio.com/git/_build?definitionId=4 > > Derrick Stolee (3): > midx: fix broken free() in close_midx() > midx: close multi-pack-index on repack > multi-pack-index: define GIT_TEST_MULTI_PACK_INDEX > > builtin/repack.c | 7 +++++-- > midx.c | 26 ++++++++++++++++++++------ > midx.h | 6 +++++- > t/README | 4 ++++ > t/t5310-pack-bitmaps.sh | 1 + > t/t5319-multi-pack-index.sh | 2 +- > t/t9300-fast-import.sh | 2 +- > 7 files changed, 37 insertions(+), 11 deletions(-) > > > base-commit: 5a0cc8aca797dbd7d2be3b67458ff880ed45cddf I should explicitly mention that this base commit is different as otherwise I will conflict with ds/multi-pack-verify with the new prototype in midx.h. Thanks, -Stolee