Re: [PATCH 2/3] midx: close multi-pack-index on repack

From: Stefan Beller <sbeller@google.com>
Date: Oct 9, 2018, 18:15 UTC
Message-ID: <CAGZ79kZHEco4KJXzGDfVTtp9ad1EqQdHCe4Y9yVMGGiAECjUQQ@mail.gmail.com>
In-Reply-To: <8b5dbe3d-b382-bf48-b524-d9e8a074ac4d@gmail.com>

On Tue, Oct 9, 2018 at 7:11 AM Derrick Stolee <stolee@gmail.com> wrote:

>
> CC Stefan: Is there a plan to make get_object_directory() take a
> repository parameter?

Not an immediate plan. Regarding the large refactorings I am mostly waiting for nd/the-index to stabilize (which may be stable enough by now) before proceeding. Specifically 2abf350385 (revision.c: remove implicit dependency on the_index, 2018-09-21) is a missing piece that I want to build on.

My next step is to look into making use of the refactorings that we did over the last year, so I'd rather look into more submodule code again.

To come back to your question:
    git grep get_object_directory |wc -l
    30
    git grep "objects->objectdir" |wc -l
    11
2 out of the 11 matches are from the implementation of get_object_directory

So either we'd actually teach get_object_directory to take a repository and inspect the 11 occurrences of direct access to objects->objectdir or we'd view get_object_directory() as a fancy wrapper, that we might want to drop eventually.