Re: [PATCH v3 02/11] i18n: refactor "%s, %s and %s are mutually exclusive"
- From
Jean-Noël AVILA <jn.avila@free.fr>
- Date
- Dec 31, 2021, 17:05 UTC
- Message-ID
- <3844495.otZVHuhvFT@cayenne>
- In-Reply-To
- <xmqqfsq9pw4d.fsf@gitster.g>
On Thursday, 30 December 2021 23:26:42 CET Junio C Hamano wrote:
Show 9 quoted lines
> "Jean-Noël Avila via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
> > if (use_stdout + rev.diffopt.close_file + !!output_directory > 1)
> > - die(_("--stdout, --output, and --output-directory are mutually exclusive"));
> > + die(_("options '%s', '%s' and '%s' cannot be used together"), "--stdout", "--output", "--output-directory");
>
> We probably want to preserve the Oxford comma here, and unify the
> ones that didn't use Oxford comma to use it.
> Oh. I wasn't even aware of this holy war (https://en.wikipedia.org/wiki/Serial_comma). It would be good to add this style specification for writing our messages and documents.
Will make another pass.
Thanks