git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/1] Makefile: improve SPARSE_FLAGS customisation

From
Ramsay Jones <ramsay@ramsayjones.plus.com>
Date
Feb 4, 2019, 19:20 UTC
Message-ID
<365a9539-4ce1-121a-ec8c-2e52a5828091@ramsayjones.plus.com>
In-Reply-To
<xmqqwomfv2w5.fsf@gitster-ct.c.googlers.com>
On 04/02/2019 18:12, Junio C Hamano wrote:
Show 16 quoted lines
> Ramsay Jones <ramsay@ramsayjones.plus.com> writes:
> 
>>> Thanks for a detailed and clear explanation here and in the cover
>>> letter.  I agree with the motivation and most of the things I see in
>>> this patch, but one thing that stands out at me is if we still want
>>> to += append to SP_EXTRA_FLAGS in target specific way.  Before this
>>> patch, because SPARSE_FLAGS was a dual use variable, it needed +=
>>> appending to it in these two places, but that rationale is gone with
>>> this patch.
>>
>> As Luc surmised, in his reply, my intention was that SP_EXTRA_FLAGS
>> should be used for any 'internal' settings (not just the target
>> specific settings), whereas SPARSE_FLAGS would now be used _only_ for
>> user customisation.
> 
> OK, if that is the case, then not using "+= append" on SP_EXTRA_FLAGS

Err, no, that clearly wouldn't be an improvement! As I said above, this is not just for target specific settings.

Am I missing something?

ATB, Ramsay Jones

Previous: Junio C HamanoNext: Junio C Hamano
Message 6 of 8 in “Makefile: improve SPARSE_FLAGS customisation”
  1. 1/1 Makefile: improve SPARSE_FLAGS customisationRamsay Jones, Feb 1, 2019
  2. Junio C HamanoFeb 1, 2019
  3. Luc Van OostenryckFeb 1, 2019
  4. Ramsay JonesFeb 3, 2019
  5. Junio C HamanoFeb 4, 2019
  6. Ramsay JonesFeb 4, 2019
  7. Junio C HamanoFeb 4, 2019
  8. Ramsay JonesFeb 4, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.