Re: [PATCH 1/1] Makefile: improve SPARSE_FLAGS customisation

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 4, 2019, 18:12 UTC
Message-ID: <xmqqwomfv2w5.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <4a8f6b3f-3844-b4e8-2ed2-4078b592dd4b@ramsayjones.plus.com>

Ramsay Jones <ramsay@ramsayjones.plus.com> writes:

Show 12 quoted lines

>> Thanks for a detailed and clear explanation here and in the cover
>> letter.  I agree with the motivation and most of the things I see in
>> this patch, but one thing that stands out at me is if we still want
>> to += append to SP_EXTRA_FLAGS in target specific way.  Before this
>> patch, because SPARSE_FLAGS was a dual use variable, it needed +=
>> appending to it in these two places, but that rationale is gone with
>> this patch.
>
> As Luc surmised, in his reply, my intention was that SP_EXTRA_FLAGS
> should be used for any 'internal' settings (not just the target
> specific settings), whereas SPARSE_FLAGS would now be used _only_ for
> user customisation.

OK, if that is the case, then not using "+= append" on SP_EXTRA_FLAGS and initializing it without allowing environment would be two improvements that can make the intention more clear, I think.

> Anyway, its late, so I will look at redoing the patches soon.

Thanks.