From: Ramsay Jones Date: Mon, 04 Feb 2019 19:20:12 GMT Subject: Re: [PATCH 1/1] Makefile: improve SPARSE_FLAGS customisation Message-ID: <365a9539-4ce1-121a-ec8c-2e52a5828091@ramsayjones.plus.com> In-Reply-To: On 04/02/2019 18:12, Junio C Hamano wrote: > Ramsay Jones writes: > >>> Thanks for a detailed and clear explanation here and in the cover >>> letter. I agree with the motivation and most of the things I see in >>> this patch, but one thing that stands out at me is if we still want >>> to += append to SP_EXTRA_FLAGS in target specific way. Before this >>> patch, because SPARSE_FLAGS was a dual use variable, it needed += >>> appending to it in these two places, but that rationale is gone with >>> this patch. >> >> As Luc surmised, in his reply, my intention was that SP_EXTRA_FLAGS >> should be used for any 'internal' settings (not just the target >> specific settings), whereas SPARSE_FLAGS would now be used _only_ for >> user customisation. > > OK, if that is the case, then not using "+= append" on SP_EXTRA_FLAGS Err, no, that clearly wouldn't be an improvement! As I said above, this is not just for target specific settings. Am I missing something? ATB, Ramsay Jones