git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Honor HP C's noreturn attribute

From
MRMichal Rokos <rokos@nextsoft.cz>
Date
Mar 8, 2011, 22:09 UTC
Message-ID
<3597D63F-589A-4BD5-B052-FA720A593301@nextsoft.cz>
In-Reply-To
<7v4o7dfndw.fsf@alter.siamese.dyndns.org>
Dear Junio,
On 8.3.2011, at 20:00, Junio C Hamano wrote:
Show 12 quoted lines
> Michal Rokos <rokos@nextsoft.cz> writes:
> 
>> The __HP_cc define detects the HP C compiler version. Precede the
>> __GNUC__ check so it works well when compiling with HP C using -Agcc
>> option that enables partial support for the GNU C dialect. The -Agcc
>> defines the __GNUC__ too.
> 
> I love it when people write a very readable log message to explain why the
> patch _has_ to be the way it is.  Very good job.
> 
> Except for the overlooooooooong lines in the message, which I line-wrapped
> locally before applying, that is.

thank you for your review. I will try to improve overall patch and the commit log quality when sending something more.

Michal
--
Michal Rokos

NextSoft spol. s r.o. Vyskočilova 1/1410 140 21 Praha 4 Czech Republic mobile: +420 736 646 591 fax: +420 267 224 307 e-mail: rokos@nextsoft.cz

Previous: Piotr Krukowiecki
Message 4 of 4 in “Honor HP C's noreturn attribute”
  1. Honor HP C's noreturn attributeMichal Rokos, Mar 7, 2011
  2. Junio C HamanoMar 8, 2011
  3. Piotr KrukowieckiMar 8, 2011
  4. Michal RokosMar 8, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.