From: Michal Rokos Date: Tue, 08 Mar 2011 22:09:41 GMT Subject: Re: [PATCH] Honor HP C's noreturn attribute Message-ID: <3597D63F-589A-4BD5-B052-FA720A593301@nextsoft.cz> In-Reply-To: <7v4o7dfndw.fsf@alter.siamese.dyndns.org> Dear Junio, On 8.3.2011, at 20:00, Junio C Hamano wrote: > Michal Rokos writes: > >> The __HP_cc define detects the HP C compiler version. Precede the >> __GNUC__ check so it works well when compiling with HP C using -Agcc >> option that enables partial support for the GNU C dialect. The -Agcc >> defines the __GNUC__ too. > > I love it when people write a very readable log message to explain why the > patch _has_ to be the way it is. Very good job. > > Except for the overlooooooooong lines in the message, which I line-wrapped > locally before applying, that is. thank you for your review. I will try to improve overall patch and the commit log quality when sending something more. Michal -- Michal Rokos NextSoft spol. s r.o. Vyskočilova 1/1410 140 21 Praha 4 Czech Republic mobile: +420 736 646 591 fax: +420 267 224 307 e-mail: rokos@nextsoft.cz