Re: [PATCH] Honor HP C's noreturn attribute

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 8, 2011, 19:00 UTC
Message-ID: <7v4o7dfndw.fsf@alter.siamese.dyndns.org>
In-Reply-To: <32EABE0E-2447-4189-A3CE-05B68A5E18EF@nextsoft.cz>

Michal Rokos <rokos@nextsoft.cz> writes:

Show 10 quoted lines

> HP C for Integrity servers (Itanium) gained support for noreturn
> attribute sometime in 2006. It was released in Compiler Version A.06.10
> and made available in July 2006.
>
> The __HP_cc define detects the HP C compiler version. Precede the
> __GNUC__ check so it works well when compiling with HP C using -Agcc
> option that enables partial support for the GNU C dialect. The -Agcc
> defines the __GNUC__ too.
>
> Signed-off-by: Michal Rokos <michal.rokos@nextsoft.cz>

We tend to prefer new code be appended at the end of if/elif/.../then/fi cascade when there is no strong reason to do otherwise; your log message clearly explains why this particular #if needs to come before the existing one.

I love it when people write a very readable log message to explain why the patch _has_ to be the way it is. Very good job.

Except for the overlooooooooong lines in the message, which I line-wrapped locally before applying, that is.

Thanks.