Re: [PATCH (v2) 2/2] rebase -i: teach --onto A...B syntax
- From
Avery Pennarun <apenwarr@gmail.com>
- Date
- Jan 8, 2010, 20:16 UTC
- Message-ID
- <32541b131001081216p27d7e29bu269755db895128@mail.gmail.com>
- In-Reply-To
- <7vtyux3bx1.fsf@alter.siamese.dyndns.org>
2010/1/7 Junio C Hamano <gitster@pobox.com>:
Show 7 quoted lines
> I am a bit unhappy about the duplication. The text of this function is > different from the one in "rebase" proper, but they implement essentially > the same logic. I was tempted to suggest having a common helper function, > but as Dscho mentioned "rebase -i" implementation does not share much with > "rebase" (even though it shares the external command line interface from > the end user's point of view), and I don't see a readily available place > (other than in git-sh-setup) to do so.
Is there a reason that non-interactive rebase can't just be implemented as "git rebase -i" but without actually launching an editor to edit the commit list?
This would resolve any other inconsistencies between the two as well, notably that non-interactive rebase sometimes refuses to do the rebase I requested because "Current branch master is up to date," while interactive rebase is willing to do it. (Personally I prefer the latter behaviour, since I don't like tools that think they're smarter than me :))
Avery