Re: [PATCH/RFC] git-svn: sanitize_remote_name should accept underscores.

From: Avery Pennarun <apenwarr@gmail.com>
Date: Jun 25, 2008, 15:01 UTC
Message-ID: <32541b130806250801p1508d15axc610f335b8d235ef@mail.gmail.com>
In-Reply-To: <20080625074548.GA8984@hand.yhbt.net>

On 6/25/08, Eric Wong <normalperson@yhbt.net> wrote:

Show 6 quoted lines

> No, nothing to do with DNS hostnames in the remote names.  I think I
>  just looked at remotes2config.sh one day and used it as a reference :x
>
>  It's late and I've had a rough few days, but shouldn't
>  sanitize_remote_name() just escape . and "?  Right now it's converting
>  stuff to . which has me very confused...

I think there might be higher-level problems here: what is it sanitizing anyway, and why? If it found my D2007_Win32 svn-remote entry in the config (as it seems to have done when trying to locate its parent branch during fetch), and *then* it sanitized it to D2007.Win32, that doesn't even make any sense. Clearly something straight from the config file doesn't need to be sanitized.

However, I don't understand the code well enough to be able to say a) whether that's exactly what happened, or b) other places where sanitize_remote_name() *is* important, or c) whether sanitize_remote_name() is even correct.

Have fun,

Avery