[PATCH/RFC] git-svn: sanitize_remote_name should accept underscores.

From: Avery Pennarun <apenwarr@gmail.com>
Date: Jun 24, 2008, 15:54 UTC
Message-ID: <1214322898-9272-1-git-send-email-apenwarr@gmail.com>

Without this patch, git-svn failed with the error:
 config --get svn-remote.D2007.Win32.url: command returned error: 1

...upon trying to automatically follow a link from a child branch back to its parent branch D2007_Win32 (note the underscore, not dot, separating the two words).

Note that I have each of my branches defined (by hand) as separate svn-remote entries in .git/config since my svn repository layout is nonstandard.

Signed-off-by: Avery Pennarun <apenwarr@gmail.com>

--- I'm not sure why sanitize_remote_name is so picky about allowed characters, but underscore should certainly be allowed. I'm worried that this has revealed a more serious problem, since presumably sanitizing the name shouldn't break anything in any case.

---
 git-svn.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/git-svn.perl b/git-svn.perl
index 4c9c59b..263d66c 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -1465,7 +1465,7 @@ sub verify_remotes_sanity {
 # we allow more chars than remotes2config.sh...
 sub sanitize_remote_name {
 	my ($name) = @_;
-	$name =~ tr{A-Za-z0-9:,/+-}{.}c;
+	$name =~ tr{A-Za-z0-9:,_/+-}{.}c;
 	$name;
 }

-- 
1.5.6.56.g29b0d