Re: [PATCH/RFC] git-svn: sanitize_remote_name should accept underscores.

From: Eric Wong <normalperson@yhbt.net>
Date: Jun 25, 2008, 07:45 UTC
Message-ID: <20080625074548.GA8984@hand.yhbt.net>
In-Reply-To: <7vfxr23s6m.fsf@gitster.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> wrote:

Show 14 quoted lines

> Eric Wong <normalperson@yhbt.net> writes:
> 
> > Wait, nevermind, this is for remotes, not remote *branches*.
> >
> > Umm... are underscores now allowed in git config files?
> 
> In
> 
> 	[foo "bar"] baz = value
> 
> foo and baz must be config.c::iskeychar() (and baz must be isalpha()), but
> "bar" can be almost anything.
> 
> Isn't "not underscore" coming from DNS hostname part restriction?

No, nothing to do with DNS hostnames in the remote names. I think I just looked at remotes2config.sh one day and used it as a reference :x

It's late and I've had a rough few days, but shouldn't sanitize_remote_name() just escape . and "? Right now it's converting stuff to . which has me very confused...

-- 
Eric Wong (in need of sleep and sanity atm...)