git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: git svn --add-author-from implies --use-log-author

From
Avery Pennarun <apenwarr@gmail.com>
Date
Jun 23, 2008, 20:12 UTC
Message-ID
<32541b130806231312l679aba31ra3daac2bb634cf1b@mail.gmail.com>
In-Reply-To
<485BB134.9080203@mircea.bardac.net>
On 6/20/08, Mircea Bardac <dev@mircea.bardac.net> wrote:
Show 13 quoted lines
> > when running git svn dcommit --add-author-from on a git-svn repository,
> > --use-log-author is not implied by itself. This causes the rewritten history
> > to not show the author in the way most users would expect it to be, "Name
> > <email@domain.tld>", but instead "<user@uuid>".
> >
> > Instead of forcing people to write "svn dcommit --add-author-from
> > --use-log-author", is it a bad move to imply the last argument, making the
> > history look more user-friendly to start with?
>
>  The documentation mentions that these 2 parameters are for init and, like
> other parameters, I had the feeling they will affect either the "init"
> process or the entire existance of the repository. Now that I look better, I
> see that there is no "config" note next to them.

They are separate options; --add-author-from affects dcommit (but not fetch or clone), while --use-log-author affects fetch and clone (but not dcommit). They do different things, and I can imagine wanting one and not the other, so having one imply the other isn't very safe.

You can set config options for these, however:

git config svn.addAuthorFrom true git config svn.useLogAuthor true

(I actually use "git config --global" to set these on my system so they apply to all my git-svn repositories.)

>  I would also like some option to stop pushing a commit if it doesn't have
> any From/Signed-off-by line in it.
[...]
>  P.S. I am very curious why using From and not Signed-off-by. I had the
> feeling that Signed-off-by is being used to also mark the path of a patch.
> Also, is there a centralized list of all the ways a patch can be "marked"

Signed-off-by is a legal declaration. Please read the documentation carefully before using it.

From: is automatically added (when you enable the option and there's
no Signed-off-by or From already) and is just informational.
Have fun,
Avery
Previous: Mircea BardacNext: Mircea Bardac
Message 3 of 7 in “git svn --add-author-from implies --use-log-author”
  1. Fredrik SkolmliJun 20, 2008
  2. Mircea BardacJun 20, 2008
  3. Avery PennarunJun 23, 2008
  4. Mircea BardacJun 23, 2008
  5. Avery PennarunJun 23, 2008
  6. Fredrik SkolmliJun 24, 2008
  7. git-svn docs: mention svn.addAuthorFrom and svn.useLogAuthor config options.Avery Pennarun, Jun 24, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.