From: Avery Pennarun <apenwarr@gmail.com>
Date: Mon, 23 Jun 2008 20:12:37 GMT
Subject: Re: git svn --add-author-from implies --use-log-author
Message-ID: <32541b130806231312l679aba31ra3daac2bb634cf1b@mail.gmail.com>
In-Reply-To: <485BB134.9080203@mircea.bardac.net>

On 6/20/08, Mircea Bardac <dev@mircea.bardac.net> wrote:
> > when running git svn dcommit --add-author-from on a git-svn repository,
> > --use-log-author is not implied by itself. This causes the rewritten history
> > to not show the author in the way most users would expect it to be, "Name
> > <email@domain.tld>", but instead "<user@uuid>".
> >
> > Instead of forcing people to write "svn dcommit --add-author-from
> > --use-log-author", is it a bad move to imply the last argument, making the
> > history look more user-friendly to start with?
>
>  The documentation mentions that these 2 parameters are for init and, like
> other parameters, I had the feeling they will affect either the "init"
> process or the entire existance of the repository. Now that I look better, I
> see that there is no "config" note next to them.

They are separate options; --add-author-from affects dcommit (but not
fetch or clone), while --use-log-author affects fetch and clone (but
not dcommit).  They do different things, and I can imagine wanting one
and not the other, so having one imply the other isn't very safe.

You can set config options for these, however:

git config svn.addAuthorFrom true
git config svn.useLogAuthor true

(I actually use "git config --global" to set these on my system so
they apply to all my git-svn repositories.)

>  I would also like some option to stop pushing a commit if it doesn't have
> any From/Signed-off-by line in it.
[...]
>  P.S. I am very curious why using From and not Signed-off-by. I had the
> feeling that Signed-off-by is being used to also mark the path of a patch.
> Also, is there a centralized list of all the ways a patch can be "marked"

Signed-off-by is a legal declaration.  Please read the documentation
carefully before using it.

From: is automatically added (when you enable the option and there's
no Signed-off-by or From already) and is just informational.

Have fun,

Avery