Re: git svn --add-author-from implies --use-log-author

From: Avery Pennarun <apenwarr@gmail.com>
Date: Jun 23, 2008, 21:31 UTC
Message-ID: <32541b130806231431r61da1f02v663463cedb5b96ef@mail.gmail.com>
In-Reply-To: <48601432.2090707@mircea.bardac.net>

On 6/23/08, Mircea Bardac <dev@mircea.bardac.net> wrote:

Show 18 quoted lines

>  Avery Pennarun wrote:
>
> > You can set config options for these, however:
> >
> > git config svn.addAuthorFrom true
> > git config svn.useLogAuthor true
> >
> > (I actually use "git config --global" to set these on my system so
> > they apply to all my git-svn repositories.)
>
>  Oh great. This is what I actually wanted. Makes a lot more sense to have
> them as (global) variables.
>
>  My initial thought was that there are (somewhere) some variables being set
> for the repository by using --add-author-from and --use-log-author with "git
> svn clone ...". I find this quite intuitive (and maybe this should be
> default?). I can't see a reason for using these options once and not using
> them later, but it might just be me.

I agree, it's a good idea to save them to the config at git svn clone time.

When I added --add-author-from I just did it like --use-log-author, then I had to read the source code to find out how to set them as config variables :)

I'm sure some patches (at least for the documentation) would be welcomed.

>  I have found that Documentation/SubmittingPatches contains info on how to
> use "Signed-off-by:"/"Acked-by:"/a little bit of "From:" but, as far as I
> remember, others have been/are used. Are they all gathered somewhere, as
> recommendations?

I don't know of any definitive reference, but Signed-off-by and Acked-by seem to be the important ones. From: (as part of the commit message) seems to be a git-svn extension that I invented. From: (as a header in the commit message) is interpreted as the committer name by git-am, I think, but you almost never need that.

Have fun,

Avery