git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t3411: Fix test 1 for case-insensitive file systems

From
Brian Gernhardt <benji@silverinsanity.com>
Date
Feb 3, 2009, 17:11 UTC
Message-ID
<2D4586A6-ADAC-4B6E-8B42-2CBD76E0304C@silverinsanity.com>
In-Reply-To
<alpine.DEB.1.00.0902031752230.6573@intel-tinevez-2-302>
On Feb 3, 2009, at 11:53 AM, Johannes Schindelin wrote:
Show 11 quoted lines
> On Tue, 3 Feb 2009, Brian Gernhardt wrote:
>
>> This change appears to have been forgotten, but does fix the  
>> problems I
>> was having.  Junio, can this make it into the official repo instead  
>> of
>> floating around in my local?  I'd send in a patch, but it was your  
>> code
>> and I don't want to take credit for it.
>
> Top-poster!

Well, yes. I wasn't replying to anything in the e-mail, I just wanted to bring it back to attention.

> Besides, I think that my latest comment still stands there: testing  
> is not
> good enough, code inspection is required if something expects the file
> names as they used to be.

As far as I can tell, no test relies on the auto-generated name of the test file. In fact, only t3411 uses that feature at all and it only performs operations on commits. All other uses of test_commit give a filename (even though many of them don't appear to use the file).

~~ Brian
Previous: Johannes SchindelinNext: Johannes Schindelin
Message 8 of 17 in “t3411: Fix test 1 for case-insensitive file systems”
  1. t3411: Fix test 1 for case-insensitive file systemsBrian Gernhardt, Jan 29, 2009
  2. Johannes SchindelinJan 29, 2009
  3. Junio C HamanoJan 29, 2009
  4. Johannes SchindelinJan 29, 2009
  5. Brian GernhardtJan 29, 2009
  6. Brian GernhardtFeb 3, 2009
  7. Johannes SchindelinFeb 3, 2009
  8. Brian GernhardtFeb 3, 2009
  9. Johannes SchindelinFeb 3, 2009
  10. Brian GernhardtFeb 3, 2009
  11. Johannes SchindelinFeb 3, 2009
  12. Brian GernhardtFeb 3, 2009
  13. Junio C HamanoFeb 3, 2009
  14. Brian GernhardtFeb 3, 2009
  15. Johannes SchindelinFeb 3, 2009
  16. Johannes SchindelinFeb 3, 2009
  17. Junio C HamanoFeb 4, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.