Re: [PATCH] t3411: Fix test 1 for case-insensitive file systems

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Feb 3, 2009, 20:38 UTC
Message-ID: <alpine.DEB.1.00.0902032132130.9822@pacific.mpi-cbg.de>
In-Reply-To: <7vy6wn9wdj.fsf@gitster.siamese.dyndns.org>

Hi,

On Tue, 3 Feb 2009, Junio C Hamano wrote:

> I'll try to find time myself to triple check if you two want to, even 
> though it is known that I often get tripped by the same kind of 
> brain-slippage as Dscho when Dscho does get tripped, so my auditing 
> might not add much to the collective confidence level ;-).

Thanks ;-)

I inspected all files that git grep -p showed me, and I see that t3412 uses the file names, but passes explicit parameters to test_commit for them. So that is fine, too.

Just as a matter of preference, I'd not downcase, but instead append a ".file" in test_commit, but that's not a strong preference. (I'd not downcase, because that was done only to prevent the tag to have the same name as the file, but that did not work...)

Ciao, Dscho