From: Brian Gernhardt <benji@silverinsanity.com>
Date: Tue, 03 Feb 2009 17:11:01 GMT
Subject: Re: [PATCH] t3411: Fix test 1 for case-insensitive file systems
Message-ID: <2D4586A6-ADAC-4B6E-8B42-2CBD76E0304C@silverinsanity.com>
In-Reply-To: <alpine.DEB.1.00.0902031752230.6573@intel-tinevez-2-302>


On Feb 3, 2009, at 11:53 AM, Johannes Schindelin wrote:

> On Tue, 3 Feb 2009, Brian Gernhardt wrote:
>
>> This change appears to have been forgotten, but does fix the  
>> problems I
>> was having.  Junio, can this make it into the official repo instead  
>> of
>> floating around in my local?  I'd send in a patch, but it was your  
>> code
>> and I don't want to take credit for it.
>
> Top-poster!

Well, yes.  I wasn't replying to anything in the e-mail, I just wanted  
to bring it back to attention.

> Besides, I think that my latest comment still stands there: testing  
> is not
> good enough, code inspection is required if something expects the file
> names as they used to be.

As far as I can tell, no test relies on the auto-generated name of the  
test file.  In fact, only t3411 uses that feature at all and it only  
performs operations on commits.  All other uses of test_commit give a  
filename (even though many of them don't appear to use the file).

~~ Brian