Re: [PATCH 7/8] replace and remove run_command_v_opt_cd_env_tr2()

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Oct 27, 2022, 22:46 UTC
Message-ID: <221028.86ilk4ano3.gmgdl@evledraar.gmail.com>
In-Reply-To: <f26f7974-3e87-2ddf-6eeb-5d97f80a4e0d@web.de>

On Thu, Oct 27 2022, René Scharfe wrote:

Show 10 quoted lines

> diff --git a/run-command.h b/run-command.h
> index 482da7f60c..04bd07dc7a 100644
> --- a/run-command.h
> +++ b/run-command.h
> @@ -233,23 +233,15 @@ int run_auto_maintenance(int quiet);
>  #define RUN_CLOSE_OBJECT_STORE		(1<<7)
>
>  /**
> - * Convenience functions that encapsulate a sequence of
> + * Convenience function that encapsulate a sequence of

Maybe we shouldn't bother, because we remove this altogether in 8/8, but this has a grammar error, should be:

	Convenience function that encapsulates a sequence of

Or:

	A convenience function that encapsulates a sequence of

Not:

	Convenience function that encapsulate a sequence of

If you're re-rolling I think just dropping this hunk is better.

It can just go away entirely in 8/8. The pre-image had bad grammar anyway, so not worth fixing just to remove it later.