Re: [PATCH 11/12] fsmonitor: test updates

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Oct 18, 2022, 12:42 UTC
Message-ID: <221018.86mt9ti9oq.gmgdl@evledraar.gmail.com>
In-Reply-To: <743bdacded5183b5b11c9f19c24b07fa26eded24.1665326258.git.gitgitgadget@gmail.com>

On Sun, Oct 09 2022, Eric DeCosta via GitGitGadget wrote:

> From: Eric DeCosta <edecosta@mathworks.com>

Show 6 quoted lines

> +wait_for_update () {
> +	func=$1 &&
> +	file=$2 &&
> +	sz=$(wc -c < "$file") &&
> +	last=0 &&
> +	$func &&

Odd not to quote "$func" here, but anyway...

> +rename_directory () {
> +	mv dirtorename dirrenamed
> +}

...uh, we need to wrap "mv"? Why?

> -	mv dirtorename dirrenamed &&
> +	wait_for_update rename_directory "$PWD/.git/trace" &&

Just to get around some quoting issue here?

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.