Re: [PATCH v5 0/6] fsmonitor: Implement fsmonitor for Linux

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 12, 2023, 05:42 UTC
Message-ID: <xmqqzg7d8xn2.fsf@gitster.g>
In-Reply-To: <pull.1352.v5.git.git.1670882286.gitgitgadget@gmail.com>

"Eric DeCosta via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 16 quoted lines

> Goal is to deliver fsmonitor for Linux that is on par with fsmonitor for
> Windows and Mac OS.
>
> This patch set builds upon previous work for done for Windows and Mac OS to
> implement a fsmonitor back-end for Linux based on the Linux inotify API.
> inotify differs significantly from the equivalent Windows and Mac OS APIs in
> that a watch must be registered for every directory of interest (rather than
> a singular watch at the root of the directory tree) and special care must be
> taken to handle directory renames correctly.
>
> More information about inotify:
> https://man7.org/linux/man-pages/man7/inotify.7.html
>
> v4 differs from v3:
>
>  * Code review feedback

This has been dormant for full four months, and it seems to break linux-asan CI job when merged to 'seen',

  https://github.com/git/git/actions/runs/4672116751/jobs/8273938089

while the same 'seen' excluding this topic passes everything.

  https://github.com/git/git/actions/runs/4674694371

For now, I'll drop this topic from 'seen'.

Thanks.