From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Tue, 18 Oct 2022 12:42:15 GMT
Subject: Re: [PATCH 11/12] fsmonitor: test updates
Message-ID: <221018.86mt9ti9oq.gmgdl@evledraar.gmail.com>
In-Reply-To: <743bdacded5183b5b11c9f19c24b07fa26eded24.1665326258.git.gitgitgadget@gmail.com>


On Sun, Oct 09 2022, Eric DeCosta via GitGitGadget wrote:

> From: Eric DeCosta <edecosta@mathworks.com>

> +wait_for_update () {
> +	func=$1 &&
> +	file=$2 &&
> +	sz=$(wc -c < "$file") &&
> +	last=0 &&
> +	$func &&

Odd not to quote "$func" here, but anyway...

> +rename_directory () {
> +	mv dirtorename dirrenamed
> +}

...uh, we need to wrap "mv"? Why?


> -	mv dirtorename dirrenamed &&
> +	wait_for_update rename_directory "$PWD/.git/trace" &&

Just to get around some quoting issue here?