Re: [PATCH v3 0/7] Gets rid of "if reflog exists, append to it regardless of config settings"

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Nov 11, 2021, 14:38 UTC
Message-ID: <211111.86k0hevjhs.gmgdl@evledraar.gmail.com>
In-Reply-To: <CAFQ2z_NASfhdHdZrY3gK29LRK_8Guj0LZ=GgCr84k7XX2L+Dow@mail.gmail.com>

On Thu, Nov 11 2021, Han-Wen Nienhuys wrote:

Show 39 quoted lines

> On Thu, Oct 7, 2021 at 7:38 PM Junio C Hamano <gitster@pobox.com> wrote:
>> > Not really.  I think the comment on the RFC still stands, and I do
>> > not recall seeing a response to the point.
>> >
>> >     One potential harm this change will bring to us is what happens to
>> >     people who disable core.logAllRefUpdates manually after using the
>> >     repository for a while.  Their @{4} will point at the same commit no
>> >     matter how many operations are done on the current branch after they
>> >     do so.  I wouldn't mind if "git reflog disable" command is given to
>> >     the users prominently and core.logAllRefUpdates becomes a mere
>> >     implementation detail nobody has to care about---in such a world, we
>> >     could set the configuration and drop the existing reflog records at
>> >     the same time and nobody will be hurt.
>
> A git 'reflog disable' command would address your concerns, but it is
> a destructive operation, so the cure might be worse than the solution.
>
>> IIRC, the only reason why reftable implementation may want to change
>> the behaviour we have to avoid getting blamed for breaking is
>> because it cannot implement "a reflog exists, and we need to record
>> further ref movements by appending to it, no matter what the
>> configuration says" when the existing reflog is empty, because its
>> data structure lacks support for expressing "exists but empty".
>>
>> I think the behaviour change described in the title of this message
>> can be limited in the scope to hurt users a lot less, and can still
>> satisfy the goal of helping reftable not getting blamed for
>> breakage, perhaps by making the behaviour for an empty but existing
>> reflog unspecified or implementation defined per backend.
>
> If we accept implementation-dependent features, we could just leave
> the whole feature as is. I had expected more breakage, but there is
> only one test case in t1400 that needs addressing. If the test
> coverage reflects the popularity of the feature, it should be fine to
> leave this divergence in, and mark the test with REFFILES.
>
> The commits prior to the RFC should be OK for committing. In
> particular, there is a bugfix for the show-branch command. Should I
> resend those separately?

I've got some follow-up patches to what's sitting in "next" already that hoist some reffiles-specific stuff into builtin/reflog.c, I haven't tested but I expect that the behavior change is silent now in the reftable backend, i.e. it doesn't implement progress/verbose the same way, presumably.

Between that and 5ac15ad2509 (reflog tests: add --updateref tests, 2021-10-16) & 52106430dc8 (refs/files: remove "name exist?" check in lock_ref_oid_basic(), 2021-10-16) I wouldn't put too much faith in those reflog tests.

None of that should be a blocker for your series landing, just say'n. I don't trust those tests.

IMO the only meaningful way to be confident in testing these sorts of things with reftable is more of the chaos monkey approach of the GIT_TEST_* modes, i.e. we now have a WIP mode to do that for reftable that has known breakages.

We could similarly instrument the test suite to do "git reflog expire" for each ref at the end of tests, a bunch of things would break, but we could log the complete -V run and see if what breaks is different under the two backends.

I've got some WIP patches to add a similar chaos mode using "git gc --auto", and it turned up some interesting stuff. It's what I used initially to test what's now landed in ae35e16cd43 (reflog expire: don't lock reflogs using previously seen OID, 2021-08-23).