git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [Microproject] describe: pluralize tag/commit count messages

From
Jeff King <peff@peff.net>
Date
Oct 14, 2026, 09:29 UTC
Message-ID
<20261014092923.GA1344504@coredump.intra.peff.net>
In-Reply-To
<20261013204351.428800-1-antekborowski11@gmail.com>
On Tue, Oct 13, 2026 at 10:43:51PM +0200, Antoni Borowski wrote:
Show 7 quoted lines
> These two verbose messages hardcoded the English plural form
> ("tags"/"commits") inside _(), which is wrong both grammatically
> (e.g. "found 1 tags") and for i18n, since other languages have
> different plural rules than English.
> 
> Switch both to Q_() so gettext picks the correct singular/plural
> form based on the count.

OK. The patch looks obviously correct, though I do find it a little funny that we bother to translate these debug messages in the first place.

I wonder if there is even really value in keeping "--debug" here at all. But that is a somewhat bigger change.

The patch here seems OK to me in the meantime (and totally fine for a microproject).

-Peff
Previous: Antoni BorowskiNext: Junio C Hamano
Message 2 of 8 in “[Microproject] describe: pluralize tag/commit count messages”
  1. Antoni BorowskiOct 13, 2026
  2. Jeff KingOct 14, 2026
  3. Junio C HamanoOct 14, 2026
  4. [Microproject] describe: do not translate --debug outputAntoni Borowski, Oct 16, 2026
  5. Junio C HamanoOct 16, 2026
  6. [Microproject v2] describe: do not translate --debug outputAntoni Borowski, Oct 16, 2026
  7. Junio C HamanoNov 7, 2026
  8. Junio C HamanoNov 7, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.