From: Jeff King Date: Wed, 14 Oct 2026 09:29:23 GMT Subject: Re: [Microproject] describe: pluralize tag/commit count messages Message-ID: <20261014092923.GA1344504@coredump.intra.peff.net> In-Reply-To: <20261013204351.428800-1-antekborowski11@gmail.com> On Tue, Oct 13, 2026 at 10:43:51PM +0200, Antoni Borowski wrote: > These two verbose messages hardcoded the English plural form > ("tags"/"commits") inside _(), which is wrong both grammatically > (e.g. "found 1 tags") and for i18n, since other languages have > different plural rules than English. > > Switch both to Q_() so gettext picks the correct singular/plural > form based on the count. OK. The patch looks obviously correct, though I do find it a little funny that we bother to translate these debug messages in the first place. I wonder if there is even really value in keeping "--debug" here at all. But that is a somewhat bigger change. The patch here seems OK to me in the meantime (and totally fine for a microproject). -Peff