Re: [Microproject v2] describe: do not translate --debug output
Antoni Borowski <antekborowski11@gmail.com> writes:
Show 17 quoted lines
> The --debug flag is aimed at developers debugging describe's search
> strategy, not at end users. Translating this output makes it harder
> to grep for known strings, compare logs across locales, or paste
> output into upstream bug reports written in English — all things
> developers routinely need to do.
>
> transport-helper.c already follows this convention: its "Debug: ..."
> messages are plain C strings with no gettext wrapper.
>
> Drop the _() wrapper from describe_commit()'s and describe()'s
> debug-only fprintf() calls accordingly, and prefix them with
> "Debug: " to match transport-helper.c's style.
>
> Signed-off-by: Antoni Borowski <antekborowski11@gmail.com>
> ---
> builtin/describe.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
OK, looking good.
Let's mark the topic as ready for 'next'.
> - fprintf(stderr, _("No exact match on refs or tags, searching to describe\n"));
> + fprintf(stderr, "Debug: No exact match on refs or tags, searching to describe\n");Shame we do not have debugf() macro ;-)