Re: [PATCH v4 3/3] fetch, remote: retain old OIDs when pruning refs

From: Maciej Ciemborowicz <maciej.ciemborowicz@gmail.com>
Date: Sep 23, 2026, 21:02 UTC
Message-ID: <20260923210205.59543-1-maciej.ciemborowicz@gmail.com>
In-Reply-To: <xmqq4iffag6k.fsf@gitster.g>

Show 5 quoted lines

> Isn't adding a new parameter to refs_delete_refs() needed before
> this step?  The corresponding changes to refs.[ch] was done in
> [1/3], and the fact that the callsite receives this update to add an
> extra parameter this late in the series means [1/3] and [2/3] does
> not even compile, right?

You are right. I updated only some of the call sites in 1/3 and left the others for the patches that begin supplying the new arguments. As a result, the intermediate commits do not compile.

I have corrected the local series by updating every call site for the new signature in 1/3, with NULL for optional data that is supplied only by the later patches. I also built the tree after each patch. The final tree remains identical to v4.

Thanks for catching this.