Re: [PATCH v3 1/3] refs: allow callers to supply old OIDs for batch deletion
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 22, 2026, 23:31 UTC
- Message-ID
- <xmqqfqz0dfrn.fsf@gitster.g>
- In-Reply-To
- <CACQ=SRGf=cKQooiSQD+ZsG8tCAdHkCrxoW5vyPSnT=UMjSajmw@mail.gmail.com>
Maciej Ciemborowicz <maciej.ciemborowicz@gmail.com> writes:
Show 10 quoted lines
> On Tue, Sep 22, 2026 at 8:55 PM Junio C Hamano <gitster@pobox.com> wrote: > >> I think there was a comment by another reviewer on the previous >> round around this area, which was never answered. In general, it is >> a polite thing to respond to review messages and see that your >> response is acknowledged before you send an updated patch. > > I'm very sorry, I didn't check my email before submitting the patch. > I'll take a look at this. By the way, I expected the review process to > be tough, but I'm starting to wonder if I'll ever get through it :).
I do not think it is the review process, but the fact that the problem you chose to tackle is not trivial to solve cleanly to begin with, and you are doing very well. Often non-trivial topics take multiple iterations to get right.
> You mentioned earlier that you could prepare a patch. Is that offer > still on the table?
I do not recall that, or I do not know a patch to do what was being discussed back then, sorry.