Re: [PATCH] push: fix --force-if-includes when remote-tracking ref has no reflog

From: Aleksei Sviridkin <f@lex.la>
Date: Sep 3, 2026, 20:00 UTC
Message-ID: <20260903200015.36849-1-f@lex.la>
In-Reply-To: <xmqq5x0mfgyh.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

> your sign-off must be the last line in the trailers.

I took Assisted-by from the kernel, which asks for it. I could not find anything either way in git's guidelines, so I followed the kernel. I will put the sign-off last in v2, and drop Assisted-by if you would rather not have it.

> It is a bit surprising to see the fallout from a change 6 years ago
> to be addressed now, and makes me wonder what else changed recently.

The date is read from uninitialized stack, so it only bites when the leftover happens to be larger than a real timestamp. That is build- and layout-dependent, not really macOS/arm64 specific. I hit a layout where it triggers every time, so the test is reliable here, but on another build it can pass by luck, as you saw.