git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] t0014: generate deprecated command names dynamically

From
Jeff King <peff@peff.net>
Date
Jul 28, 2026, 16:19 UTC
Message-ID
<20260728161949.GD639637@coredump.intra.peff.net>
In-Reply-To
<xmqqse53drwu.fsf@gitster.g>
On Tue, Jul 28, 2026 at 09:01:53AM -0700, Junio C Hamano wrote:
Show 19 quoted lines
> Jeff King <peff@peff.net> writes:
> 
> > We have a few tests related to aliasing of deprecated commands. They use
> > whatchanged and pack-redundant because those are the only two deprecated
> > commands we have. Eventually those commands will be removed, at which
> > point these tests will be checking nothing useful (they'll just be
> > regular aliases, which we already cover in other tests).
> >
> > We could remove them at that point, but the code to handle deprecated
> > commands will still remain. We probably do want to keep the tests around
> > for the eventual day that we deprecate more commands. So let's ask Git
> > for its list of deprecated commands, and if we don't have any, skip
> > those tests.
> 
> Ah, now I understand.  So HAVE_DEPRECATED prerequisite guards tests
> that require at least two deprecated commands, so that we can test
> cases with aliases that involve two commands among deprecated ones
> referring to each other.  Obviously, with 0 or 1 deprecated commands,
> there is no point to perform such tests.

Yeah. Sorry, maybe splitting the two just made it more confusing (it was really to make the diff a bit less heinous). I'm OK if you want to just squash them together (using the commit message from the second).

I suspect we could _probably_ rewrite the "looping aliases" test to also run when there's only 1 deprecated command (just looping on itself). But since we have two now, and plan to have zero later, I don't know that it's worth the effort of doing so.

-Peff
Previous: Junio C HamanoNext: brian m. carlson
Message 10 of 16 in “Failing tests with WITH_BREAKING_CHANGES”
  1. brian m. carlsonJul 28, 2026
  2. Junio C HamanoJul 28, 2026
  3. Phillip WoodJul 28, 2026
  4. Jeff KingJul 28, 2026
  5. 0/2 fix serial tests without/with breaking-changesJeff King, Jul 28, 2026
  6. 1/2 t0014: factor out choice of deprecated commandsJeff King, Jul 28, 2026
  7. Junio C HamanoJul 28, 2026
  8. 2/2 t0014: generate deprecated command names dynamicallyJeff King, Jul 28, 2026
  9. Junio C HamanoJul 28, 2026
  10. Jeff KingJul 28, 2026
  11. brian m. carlsonJul 28, 2026
  12. Phillip WoodJul 29, 2026
  13. Makefile: read configuration earlierbrian m. carlson, Jul 29, 2026
  14. Junio C HamanoJul 30, 2026
  15. Jeff KingJul 30, 2026
  16. Jeff KingJul 30, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.