git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/2] fix serial tests without/with breaking-changes

From
Jeff King <peff@peff.net>
Date
Jul 28, 2026, 14:36 UTC
Message-ID
<20260728143653.GB11894@coredump.intra.peff.net>
In-Reply-To
<20260728135532.GA11894@coredump.intra.peff.net>
On Tue, Jul 28, 2026 at 09:55:32AM -0400, Jeff King wrote:
> But we are in a funny limbo now for WITH_BREAKING_CHANGES. Possibly we
> could pull the value out of GIT-BUILD-OPTIONS (which I guess happens
> already via the environment) and use a prereq to skip the test.

I think we can do even a bit better. Leaving aside WITH_BREAKING_CHANGES, we should consider what will eventually happen to these tests when those deprecated commands go away. I think we want to keep them in preparation for when we have more deprecated commands.

So here's a patch.

It doesn't address the t1517 issue at all. That test can also be confused by older build products, but I don't think deprecation is particularly related. It comes from going to an old version where some now-vanished command doesn't pass the "-h" test and then traveling back to the present. Probably it could be more careful about what it considers a valid command. Right now it checks "git --list-cmds", but in theory it could be using a list generated from the Makefile.

  [1/2]: t0014: factor out choice of deprecated commands
  [2/2]: t0014: generate deprecated command names dynamically
 t/t0014-alias.sh | 32 ++++++++++++++++++++------------
 1 file changed, 20 insertions(+), 12 deletions(-)
-Peff
Previous: Jeff KingNext: Jeff King
Message 5 of 16 in “Failing tests with WITH_BREAKING_CHANGES”
  1. brian m. carlsonJul 28, 2026
  2. Junio C HamanoJul 28, 2026
  3. Phillip WoodJul 28, 2026
  4. Jeff KingJul 28, 2026
  5. 0/2 fix serial tests without/with breaking-changesJeff King, Jul 28, 2026
  6. 1/2 t0014: factor out choice of deprecated commandsJeff King, Jul 28, 2026
  7. Junio C HamanoJul 28, 2026
  8. 2/2 t0014: generate deprecated command names dynamicallyJeff King, Jul 28, 2026
  9. Junio C HamanoJul 28, 2026
  10. Jeff KingJul 28, 2026
  11. brian m. carlsonJul 28, 2026
  12. Phillip WoodJul 29, 2026
  13. Makefile: read configuration earlierbrian m. carlson, Jul 29, 2026
  14. Junio C HamanoJul 30, 2026
  15. Jeff KingJul 30, 2026
  16. Jeff KingJul 30, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.