git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Failing tests with WITH_BREAKING_CHANGES

From
Jeff King <peff@peff.net>
Date
Jul 28, 2026, 13:55 UTC
Message-ID
<20260728135532.GA11894@coredump.intra.peff.net>
In-Reply-To
<758dbec3-7657-4342-8b74-7e59cdf88b5e@gmail.com>
On Tue, Jul 28, 2026 at 02:31:03PM +0100, Phillip Wood wrote:
Show 5 quoted lines
> I find t1517 fails quite often for me due to cruft from a previous build
> when a different branch was checked out. I wonder if there is a command that
> is no-longer built by WITH_BREAKING_CHANGES whose executable still exists in
> the build directory from a previous build. Its not clear to me why the alias
> tests might be failing though.

It's the same reason. We test looping through deprecated aliases using whatchanged and pack-redundant. When those are builtin but deprecated (like now) we allow aliases. After the breaking-changes split, those names are not special at all, and they are subject to the usual alias rules. If there is crufty git-whatchanged in your build directory, then that is an "external command" unknown to Git and you are not allowed to alias over it.

The test in t0014 that covers this should be removed after the breaking changes actually land (those commands won't handled specially, so it's not different than the normal alias loop detection).

But we are in a funny limbo now for WITH_BREAKING_CHANGES. Possibly we could pull the value out of GIT-BUILD-OPTIONS (which I guess happens already via the environment) and use a prereq to skip the test.

-Peff
Previous: Phillip WoodNext: Jeff King
Message 4 of 16 in “Failing tests with WITH_BREAKING_CHANGES”
  1. brian m. carlsonJul 28, 2026
  2. Junio C HamanoJul 28, 2026
  3. Phillip WoodJul 28, 2026
  4. Jeff KingJul 28, 2026
  5. 0/2 fix serial tests without/with breaking-changesJeff King, Jul 28, 2026
  6. 1/2 t0014: factor out choice of deprecated commandsJeff King, Jul 28, 2026
  7. Junio C HamanoJul 28, 2026
  8. 2/2 t0014: generate deprecated command names dynamicallyJeff King, Jul 28, 2026
  9. Junio C HamanoJul 28, 2026
  10. Jeff KingJul 28, 2026
  11. brian m. carlsonJul 28, 2026
  12. Phillip WoodJul 29, 2026
  13. Makefile: read configuration earlierbrian m. carlson, Jul 29, 2026
  14. Junio C HamanoJul 30, 2026
  15. Jeff KingJul 30, 2026
  16. Jeff KingJul 30, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.