git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] fsmonitor-watchman: fix variable reference and remove redundant code

From
PTPaul Tarjan <paul@paultarjan.com>
Date
Feb 28, 2026, 17:33 UTC
Message-ID
<20260228173314.97952-1-github@paulisageek.com>
In-Reply-To
<CAOTNsDyy2ZQDhkVyML6j5naS_UC=SjE915hjygj+QmKe4bqc=A@mail.gmail.com>
Koji Nakamaru <koji.nakamaru@gree.net> writes:
Show 6 quoted lines
> Although I don't have much experience with the Watchman backend, the
> fixes look correct to me.
>
> One suggestion: it seems we can make the code even cleaner by removing
> $retry and its associated logic, as they appear to be no longer
> necessary after these changes.

Good point. $retry only existed to prevent the infinite recursion from the recursive launch_watchman() call, so now that we've removed that call it's dead code. Cleaned it up in v2.

Thanks for the review, Paul

Previous: Koji NakamaruNext: brian m. carlson
Message 5 of 8 in “fsmonitor: fix two bugs in watchman hook retry path”
  1. fsmonitor: fix two bugs in watchman hook retry pathPaul Tarjan via GitGitGadget, Jan 26, 2026
  2. Paul TarjanFeb 8, 2026
  3. Paul TarjanFeb 27, 2026
  4. Koji NakamaruFeb 28, 2026
  5. Paul TarjanFeb 28, 2026
  6. brian m. carlsonFeb 28, 2026
  7. Paul TarjanFeb 28, 2026
  8. fsmonitor-watchman: fix variable reference and remove redundant codePaul Tarjan via GitGitGadget, Feb 28, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.